[PATCH] D82258: [RegisterCoalescer] Fix IMPLICIT_DEF init removal for a register on joining

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 18 09:53:21 PDT 2020


arsenm added a comment.

Can you remove the commit message from the previous commit from this message? I found it confusing to read it here



================
Comment at: llvm/test/CodeGen/AMDGPU/coalescing_makes_lanes_undef.mir:2
+# RUN: llc -march=amdgcn -mcpu=gfx803 -run-pass simple-register-coalescing -verify-machineinstrs -o - %s | FileCheck %s
+
+---
----------------
Should have comment explaining the test


================
Comment at: llvm/test/CodeGen/AMDGPU/coalescing_makes_lanes_undef.mir:8-9
+  ; CHECK-LABEL: name: coalescing_makes_lane_undefined
+  ; CHECK-LABEL:	bb.2:
+  ; CHECK: undef %0.sub0:sgpr_64 = IMPLICIT_DEF
+  bb.0:
----------------
Probably should generate full checks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82258/new/

https://reviews.llvm.org/D82258



More information about the llvm-commits mailing list