[PATCH] D83034: [GlobalISel] Don't skip adding predicate matcher

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM. I think this is only a half solution, and it's still a problem that multiple builtin predicates will be silently ignored



================
Comment at: llvm/utils/TableGen/GlobalISelEmitter.cpp:3665
+      InsnMatcher.addPredicate<AtomicOrderingMMOPredicateMatcher>("Monotonic");
+      return InsnMatcher;
+    }
----------------
madhur13490 wrote:
> arsenm wrote:
> > How is changing this to return any different than continue? It's still treating all of these as mutually exclusive
> It is returning to the parent createAndImportSelDAGMatcher which further adds custom predicate.
OK, so this is *only* fixing custom predicate + builtin predicate. It is not fixing adding multiple builtin predicates at once. I think that can be a separate patch, but is just as broken


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83034/new/

https://reviews.llvm.org/D83034