[PATCH] D84403: [AMDGPU] Use ds_read/write_b96/b128 when possible for SDag

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 18 09:14:28 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:8411
+    if (Subtarget->hasDS96AndDS128() &&
+        VT.getStoreSize() <= (Subtarget->useDS128() ? 16 : 12) &&
+        allowsMisalignedMemoryAccessesImpl(VT.getSizeInBits(), AS,
----------------
I think <= is not right here, it needs to be == 16 or == 12


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84403/new/

https://reviews.llvm.org/D84403



More information about the llvm-commits mailing list