[PATCH] D86136: [ELF] Hide target specific methods as private

Ronak Chauhan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 18 05:46:31 PDT 2020


rochauha created this revision.
rochauha added reviewers: scott.linder, jhenderson.
Herald added subscribers: llvm-commits, s.egerton, simoncook.
Herald added a project: LLVM.
rochauha requested review of this revision.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D86136

Files:
  llvm/include/llvm/Object/ELFObjectFile.h


Index: llvm/include/llvm/Object/ELFObjectFile.h
===================================================================
--- llvm/include/llvm/Object/ELFObjectFile.h
+++ llvm/include/llvm/Object/ELFObjectFile.h
@@ -51,6 +51,12 @@
   friend class ELFSectionRef;
   friend class ELFSymbolRef;
 
+  SubtargetFeatures getMIPSFeatures() const;
+  SubtargetFeatures getARMFeatures() const;
+  SubtargetFeatures getRISCVFeatures() const;
+
+  StringRef getAMDGPUCPUName() const;
+
 protected:
   ELFObjectFileBase(unsigned int Type, MemoryBufferRef Source);
 
@@ -80,16 +86,8 @@
 
   SubtargetFeatures getFeatures() const override;
 
-  SubtargetFeatures getMIPSFeatures() const;
-
-  SubtargetFeatures getARMFeatures() const;
-
-  SubtargetFeatures getRISCVFeatures() const;
-
   Optional<StringRef> tryGetCPUName() const override;
 
-  StringRef getAMDGPUCPUName() const;
-
   void setARMSubArch(Triple &TheTriple) const override;
 
   virtual uint16_t getEType() const = 0;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86136.286260.patch
Type: text/x-patch
Size: 965 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200818/e54744db/attachment.bin>


More information about the llvm-commits mailing list