[PATCH] D86045: [llvm-dwarfdump] --statistics: switch to json::OStream. NFC

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added subscribers: Orlando, dblaikie.
jhenderson added a comment.
This revision is now accepted and ready to land.

Since this is JSON we're trying to emit, using the JSON stream makes sense to me. LGTM, but might be worth hanging on a bit to give others a chance to chime in.



================
Comment at: llvm/tools/llvm-dwarfdump/Statistics.cpp:482
+      LocationStats[0]);
   LLVM_DEBUG(
       llvm::dbgs() << Key
----------------
MaskRay wrote:
> I am not sure repeating the message in LLVM_DEBUG is useful.
> 
> I can delete them in a separate change if people think the same as me.
Not sure I've got any reasonable opinion here, since I don't really use this code or LLVM_DEBUG output ever. I'd prefer of one of the other typical users chime in here (e.g. @aprantl, @dblaikie, @Orlando)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86045/new/

https://reviews.llvm.org/D86045