[PATCH] D84822: Add documentation for target ID and ClangOffloadBundlerFormat

[Tony Tye via Phabricator via llvm-commits]

t-tye added inline comments.


================
Comment at: clang/docs/ClangOffloadBundlerFileFormat.rst:11
+
+  <bundle_entry_id>   ::= <offload_kind> "-" <target_triple> "-" <processor_or_target_id>
+
----------------
[  "-" <processor_or_target_id> ]

This is optional as some targets do not support this.


================
Comment at: clang/docs/ClangOffloadBundlerFileFormat.rst:25
+  binary is compiled. If target ID is supported by the target, this is the target ID for which the
+  device binary is compiled (see `Target ID Definition <https://llvm.org/docs/AMDGPUUsage.html#target-ids>`_).
+
----------------
(for AMD GPU see :doc:`amdgpu-target-ids`)


================
Comment at: clang/docs/ClangOffloadBundlerFileFormat.rst:87-89
+If target ID is supported, the rules of compatible offload targets in a single bundled device binary is defined
+in `AMDGPU Embedding Bundled Code Objects
+  <https://llvm.org/docs/AMDGPUUsage.html#embedding-bundled-objects>`_.
----------------
defined by the target (for AMD GPU see :doc::`amdgpu-embedding-bundled-objects`).


================
Comment at: llvm/docs/AMDGPUUsage.rst:272
 
 Target Features
 ---------------
----------------
We should move the code object V3 into a separate page so we continue to define that ABI since old code objects still exist. Then these changes can define the code object V4.


================
Comment at: llvm/docs/AMDGPUUsage.rst:2286
                                          for the definition of the mapping.
      ========== ============== ========= =======================================
 
----------------
t-tye wrote:
> Add "TargetID" attribute that is a string that is the target ID for the module.
Or is this:

<target_triple> "-" <target_id>


================
Comment at: llvm/docs/AMDGPUUsage.rst:7677
 
 .amdgcn_target <target>
 +++++++++++++++++++++++
----------------
t-tye wrote:
> <target> -> <target-id>
Or is this:

<target_triple> "-" <target_id>


================
Comment at: llvm/docs/AMDGPUUsage.rst:7680
 
 Optional directive which declares the target supported by the containing
 assembler source file. Valid values are described in
----------------
t-tye wrote:
> target ID
Or is this:

<target_triple> "-" <target_id>


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84822/new/

https://reviews.llvm.org/D84822