[PATCH] D85809: [LTO] Make setupLLVMOptimizationRemarks accept remarks hotness threshold

Mon Aug 17 15:34:49 PDT 2020

weiwang added inline comments.

================
Comment at: lld/ELF/Config.h:266
   int32_t splitStackAdjustSize;
+  unsigned optRemarksHotnessThreshold;

----------------
MaskRay wrote:
> This should be moved above
> 
> ```
>   llvm::StringRef optRemarksFilename;
>   llvm::StringRef optRemarksPasses;
>   llvm::StringRef optRemarksFormat;
> ```
Thanks for the comments! I will upload another revision to fix this, and also address Teresa's comment in https://reviews.llvm.org/D85808.  

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85809/new/

https://reviews.llvm.org/D85809