[PATCH] D85544: [OpenMPOpt] ICV tracking for calls

[Stefan Stipanovic via Phabricator via llvm-commits]

sstefan1 added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:1252
+      if (HasChanged == ChangeStatus::CHANGED && !ValuesMap.count(Entry))
+        ValuesMap.insert(std::make_pair(Entry, nullptr));
     }
----------------
jdoerfert wrote:
> What is this about?
As per IRC discussion, added TODO to avoid this. Probably in a follow up, I'll try to introduce new state and possibly make other AAs not depend on function AA as much.

This applies to the comment bellow as well.


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:1273
+    if (CalledFunction == GetterRFI.Declaration)
+      return None;
+    if (CalledFunction == SetterRFI.Declaration) {
----------------
jdoerfert wrote:
> Arguably, the value for the ICV is the getter call, so I.
The reason we return `None` here is because getters don't change the ICV.
Maybe a different name for the function would be the best solution?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85544/new/

https://reviews.llvm.org/D85544