[PATCH] D85932: [UpdateTestChecks] Match 'attributes #' at the end

[Stefan Stipanovic via Phabricator via llvm-commits]

sstefan1 added inline comments.


================
Comment at: llvm/utils/UpdateTestChecks/common.py:320
+    NamelessValue(r'LOOP',  r'!llvm.loop !', r'',              r'[0-9]+?',   r''),
+    NamelessValue(r'META',  r'metadata !',   r'',              r'[0-9]+?',  r''),
 ]
----------------
jdoerfert wrote:
> Nit: Align the columns. Maybe reorder so we have prefix and then regexp, we can then also make those a pair: `('r'%', r'...'), (...)`
I am not sure I see a place where those could be used separately. Am I missing something?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85932/new/

https://reviews.llvm.org/D85932