[PATCH] D85585: Replace TableGen range piece punctuator with '..'

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 17 11:27:42 PDT 2020


nhaehnle added a comment.

I like this. I agree with David that the goal should be to remove existing uses of the old syntax, but I think it's fine to do that in a separate patch. One small nit, apart from that LGTM.



================
Comment at: llvm/lib/TableGen/TGParser.cpp:674
 ///   RangePiece ::= INTVAL
+///   RangePiece ::= INTVAL '..' INTVAL
 ///   RangePiece ::= INTVAL '-' INTVAL
----------------
Needs to be updated to '...'


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85585/new/

https://reviews.llvm.org/D85585



More information about the llvm-commits mailing list