[PATCH] D85781: [BPI] Improve static heuristics for integer comparisons

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 17 11:20:13 PDT 2020


lebedev.ri added subscribers: efriedma, tstellar, lebedev.ri.
lebedev.ri added a comment.

In D85781#2221997 <https://reviews.llvm.org/D85781#2221997>, @MaskRay wrote:

> Some tests have non-trivial changes. Some tests are actually enhanced. In this case, it'd be nice if a separate review (or just a commit, depending on the nature of the updates) to improve the tests first. Then this review can show the differences. It would be easier for a reader to understand the improvement (and also makes reverts easier if this turns out to be insufficient)

FWIW i've already previously provided such feedback at least in https://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20200810/819028.html,
before https://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20200810/819138.html happened, and i *think* before that too.
But it seems like the feedback isn't being heard. I'm not sure what the problem is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85781/new/

https://reviews.llvm.org/D85781



More information about the llvm-commits mailing list