[PATCH] D86064: AMDGPU/GlobalISel: Match global saddr addressing mode

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 17 07:40:47 PDT 2020


foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

Looks good.



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp:3298
+  if (PtrBaseDef->getOpcode() != AMDGPU::G_PTR_ADD)
+    return None;
+
----------------
How do we handle the addressing mode where there is no saddr, just vaddr+offset?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86064/new/

https://reviews.llvm.org/D86064



More information about the llvm-commits mailing list