[PATCH] D85980: [ARM][LV] Add a preferPredicatedReductionSelect target hook

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMTargetTransformInfo.cpp:1606
+    if (!I->getType()->isIntegerTy() && !I->getType()->isFloatTy() &&
+        !I->getType()->isHalfTy()) {
+      LLVM_DEBUG(dbgs() << "Don't tail-predicate loop with non-integer/float "
----------------
SjoerdMeijer wrote:
> hey, that's new, I forgot but do we have a (negative) test for half types? :-)
Yeah, this is really to stop pointers, which can cause problem as live out values.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85980/new/

https://reviews.llvm.org/D85980