[PATCH] D85659: [PowerPC] in fixupIsDeadOrKill before RA, get def instructions by calling getVRegDef

Kai Luo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 16 19:53:59 PDT 2020


lkail added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.cpp:2677
+  if (MRI.isSSA() && StartMI->findRegisterUseOperandIdx(RegNo) < 0 &&
+      StartMI->findRegisterDefOperandIdx(RegNo) < 0) {
+    assert(Register::isVirtualRegister(RegNo) && "Must be a virtual register");
----------------
Oops, should be `findRegisterUseOperandIdx(RegNo) < 0` -> `!readsRegister(RegNo)`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85659/new/

https://reviews.llvm.org/D85659



More information about the llvm-commits mailing list