[PATCH] D85544: [OpenMPOpt] ICV tracking for calls

[Stefan Stipanovic via Phabricator via llvm-commits]

sstefan1 added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:1406
+        if (!ReplVal.hasValue() && hasTrackedValue(ICV))
+          ReplVal = nullptr;
+
----------------
jdoerfert wrote:
> why do we need the `hasTrackedValue` call (and function)?
> Caching again. And a TODO that we should look at call sites if possible.
Turns out `hasTrackedValue` is actually not needed.

As for caching, values are kind of cached inside appropriate `AAICVTrackerFunctionReturned`, `AAICVTrackerCallSiteReturned` or `AAICVTrackerCallSite`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85544/new/

https://reviews.llvm.org/D85544