[PATCH] D85838: New TableGen Programmer's Reference document

Paul C. Anagnostopoulos via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 16 10:04:07 PDT 2020


Paul-C-Anagnostopoulos marked 13 inline comments as done.
Paul-C-Anagnostopoulos added a comment.

In D85838#2219986 <https://reviews.llvm.org/D85838#2219986>, @johnwbyrd wrote:

> This concept is good, but it doesn't follow the parallel structure of headings in the rest of the document. The heading is the keyword. Use text to define the concept.

John: that is what you said about the heading for the let statement. I'm not sure I understand your objection. Can you elaborate?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85838/new/

https://reviews.llvm.org/D85838



More information about the llvm-commits mailing list