[PATCH] D84519: [llvm-objdump][AMDGPU] Detect CPU string

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 15 17:40:25 PDT 2020


MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:2109
+  if (MCPU.empty()) {
+    MCPU = Obj->tryGetCPUName().getValueOr("").str();
+  }
----------------
https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements

I think the code is self-explaining. There is no need for the comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84519/new/

https://reviews.llvm.org/D84519



More information about the llvm-commits mailing list