[PATCH] D86026: Update lld test suite to include a substitution for the current LLVM version and make the test parametric

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 15 17:25:08 PDT 2020


mehdi_amini added inline comments.


================
Comment at: lld/test/lit.cfg.py:86
 config.environment['LLD_IN_TEST'] = '1'
+config.substitutions.append(("%llvm_version", config.llvm_version))
 
----------------
int3 wrote:
> @ruiu has pushed back against using substitutions previously (in D77086). Could we just make the regex more flexible?
I already made the regex less strict, if we can leave it as-is that works for us.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86026/new/

https://reviews.llvm.org/D86026



More information about the llvm-commits mailing list