[PATCH] D85963: [SLC] sprintf(dst, "%s", str) -> strcpy(dst, str)

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 14 23:18:53 PDT 2020


mstorsjo added a comment.

This change still causes failed asserts when building source like e.g. this:

  $ cat sprintf-strcpy.c
  char *ptr; void func(void) { ptr += sprintf(ptr, "%s", ""); }
  $ clang -c sprintf-strcpy.c -O2 -target x86_64-linux-gnu
  clang: ../lib/IR/Value.cpp:473: void llvm::Value::doRAUW(llvm::Value*, llvm::Value::ReplaceMetadataUses): Assertion `New->getType() == getType() && "replaceAllUses of value with new value of different type!"' failed.

Will revert it shortly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85963/new/

https://reviews.llvm.org/D85963



More information about the llvm-commits mailing list