[PATCH] D86005: [NewPM][LoopFullUnroll] Make LoopFullUnrollPass required

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks created this revision.
aeubanks added reviewers: echristo, ychen, asbirlea.
Herald added subscribers: llvm-commits, zzheng.
Herald added a project: LLVM.
aeubanks requested review of this revision.

This is so loops should be fully unrolled are actually unrolled even when the function is optnone.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D86005

Files:
  llvm/include/llvm/Transforms/Scalar/LoopUnrollPass.h
  llvm/test/Transforms/LoopUnroll/FullUnroll.ll


Index: llvm/test/Transforms/LoopUnroll/FullUnroll.ll
===================================================================
--- llvm/test/Transforms/LoopUnroll/FullUnroll.ll
+++ llvm/test/Transforms/LoopUnroll/FullUnroll.ll
@@ -1,4 +1,5 @@
 ; RUN: opt -passes='loop-unroll-full' -disable-verify --mtriple x86_64-pc-linux-gnu -S -o - %s | FileCheck %s
+; RUN: opt -enable-npm-optnone -passes='loop-unroll-full' -disable-verify --mtriple x86_64-pc-linux-gnu -S -o - %s | FileCheck %s
 
 ; This checks that the loop full unroller will fire in the new pass manager
 ; when forced via #pragma in the source (or annotation in the code).
Index: llvm/include/llvm/Transforms/Scalar/LoopUnrollPass.h
===================================================================
--- llvm/include/llvm/Transforms/Scalar/LoopUnrollPass.h
+++ llvm/include/llvm/Transforms/Scalar/LoopUnrollPass.h
@@ -44,6 +44,7 @@
 
   PreservedAnalyses run(Loop &L, LoopAnalysisManager &AM,
                         LoopStandardAnalysisResults &AR, LPMUpdater &U);
+  static bool isRequired() { return true; }
 };
 
 /// A set of parameters used to control various transforms performed by the


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86005.285782.patch
Type: text/x-patch
Size: 1151 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200814/11a649ed/attachment.bin>