[PATCH] D85937: [flang][msvc] Split class declaration and constexpr variable definition. NFC.

Fri Aug 14 14:35:24 PDT 2020

DavidTruby added a comment.

In D85937#2219052 <https://reviews.llvm.org/D85937#2219052>, @Meinersbur wrote:

> In D85937#2219028 <https://reviews.llvm.org/D85937#2219028>, @klausler wrote:
>
>> You might have to use conditional preprocessing to make this workaround specific to MSVC.
>
> The workaround is valid C++ and works fine with every compiler. So why add a #if maze?

I also believe it will generate exactly the same code. There's no functional difference between the new proposal and the old code as far as the standard is concerned. I agree that preprocessor changes aren't necessary here.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85937/new/

https://reviews.llvm.org/D85937