[PATCH] D83507: [AssumeBundles] Fix Bug in Assume Queries

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 14 14:28:27 PDT 2020


lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.

LG
@jdoerfert ?

In D83507#2219127 <https://reviews.llvm.org/D83507#2219127>, @Tyker wrote:

> In D83507#2215586 <https://reviews.llvm.org/D83507#2215586>, @lebedev.ri wrote:
>
>> Please rebase and update the affected test :)
>
> thank you, but how did you reduced it ?

By not treating compiler as a black box - there is a (an unreduced) testcase already, and a fix, that changes the IR after optimizations.
So one just has to write an interestingness test that checks that 1. the bug is still triggered, and 2. the final IR differs with/without the fix.

I would be lying if i said that llvm-reduce got those 2mb down to these 40 lines all by itself,
there are still some rough edges that required manual intervention..


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83507/new/

https://reviews.llvm.org/D83507



More information about the llvm-commits mailing list