[PATCH] D85937: [flang][msvc] Split class declaration and constexpr variable definition. NFC.

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 14 13:25:47 PDT 2020


Meinersbur added a comment.

The pre-merge check

> clang-tidy: warning: variable 'digitString64' defined in a header file; variable definitions in header files can lead to ODR violations [misc-definitions-in-headers]

is a false positive: constexpr variables are static by default.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85937/new/

https://reviews.llvm.org/D85937



More information about the llvm-commits mailing list