[PATCH] D85973: [PowerPC] Fix thunk alignment issue when using pc-rel instruction

[Victor Huang via Phabricator via llvm-commits]

NeHuang marked 2 inline comments as done.
NeHuang added inline comments.


================
Comment at: lld/test/ELF/ppc64-thunk-alignment.s:1
+# REQUIRES: ppc
+# RUN: echo 'SECTIONS { \
----------------
MaskRay wrote:
> I don't think the additional test is necessary. The address differences should be reflected by other tests.
> 
> Having too many tests for a feature is also something we should try to avoid.
Will do. 


================
Comment at: lld/test/ELF/ppc64-toc-call-to-pcrel.s:35
 # CHECK-LABEL: caller_14
-# CHECK:       bfl 0, 0x1002003c
+# CHECK:       bfl 0, 0x10020040
 # CHECK-NEXT:  ld 2, 24(1)
----------------
MaskRay wrote:
> Doesn't it have ` <__toc_save_callee>`?
Sorry I did not quite get your point. `0x10020040` is the start address of `__toc_save_callee` stub. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85973/new/

https://reviews.llvm.org/D85973