[PATCH] D85809: [lld] Enable remarks hotness filtering in lld and llvm-lto2

Fri Aug 14 11:44:56 PDT 2020

tejohnson added a comment.

In D85809#2218725 <https://reviews.llvm.org/D85809#2218725>, @thegameg wrote:

> In D85809#2217341 <https://reviews.llvm.org/D85809#2217341>, @weiwang wrote:
>
>> I have removed the change to llvm-lto
>
> It would be nice if you can bring that back (maybe in a separate patch as Teresa suggested). I can see it being useful through ld64/libLTO, and for consistency it doesn't sound like it would cause any harm, since these options are passed as "debug options" through `-mllvm`.

Just to clarify, I wasn't suggesting putting it in another patch, but just bringing it back here (plus adding in the gold-plugin support). The other patch I was referring to was the follow on patch D85810 <https://reviews.llvm.org/D85810> where I also suggested adding support to gold-plugin.cpp.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85809/new/

https://reviews.llvm.org/D85809