[PATCH] D54749: Saturating float to int casts: Basics [1/n]

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

> Finally, something worth mentioning is that the legalization implemented here is not compatible with trapping fptoi (at least one of the expansions isn't). I don't believe trapping fptoi's are actually legal per langref, but I've also seen people adjust x86 fptoi lowering to work with trapping fptoi at some point, so I'm a bit confused on what the state here is.

The fptosi instruction doesn't have side-effects.  llvm.experimental.constrained.fptosi can raise floating-point exceptions.  I'm not sure anyone has looked at actually trapping.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54749/new/

https://reviews.llvm.org/D54749