[PATCH] D85971: [IndVarSimplify] Fix Modified status for removal of overflow intrinsics

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/SimplifyIndVar.cpp:480
 
+  Changed = true;
   return true;
----------------
I got a feeling that these eliminate functions return true/false depending on if any changes where made. So why aren't we setting Changed=true at the using side.

Otherwise I'd expect that also eliminateTrunc below should set Changed=true before returning true. Or it would be really hard to know what to expect from these functions if only some of them update Changed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85971/new/

https://reviews.llvm.org/D85971