[PATCH] D85667: Reset PAL metadata when AMDGPU traget stream finishes

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle accepted this revision.
nhaehnle added a comment.
This revision is now accepted and ready to land.

LGTM minus something rather obvious.



================
Comment at: llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp:581
 bool shouldEmitConstantsToTextSection(const Triple &TT) {
-  return TT.getOS() == Triple::AMDPAL || TT.getArch() == Triple::r600;
+  return TT.getArch() == Triple::r600;
 }
----------------
Looks like some unrelated change got into this patch? (FWIW, I usually do `arc diff @^` as part of a `git rebase -i` -- maybe newer versions of arc can do something smarter, I haven't reevaluated my workflow in some time)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85667/new/

https://reviews.llvm.org/D85667