[PATCH] D85963: [SLC] sprintf(dst, "%s", str) -> strcpy(dst, str)

Dávid Bolvanský via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 14 09:14:38 PDT 2020


xbolva00 added a comment.

In D85963#2218256 <https://reviews.llvm.org/D85963#2218256>, @efriedma wrote:

> In the case where we need the return value, there are a couple possible modifications:
>
> 1. Maybe worth checking if the length of the string is a known constant.
> 2. We could consider using stpcpy on targets where it's available.

Thanks, great suggestions;) Please check if correct.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85963/new/

https://reviews.llvm.org/D85963



More information about the llvm-commits mailing list