[PATCH] D85809: [lld] Enable remarks hotness filtering in lld and llvm-lto2

Fri Aug 14 08:29:27 PDT 2020

tejohnson added a comment.

In D85809#2217341 <https://reviews.llvm.org/D85809#2217341>, @weiwang wrote:

> In D85809#2214246 <https://reviews.llvm.org/D85809#2214246>, @tejohnson wrote:
>
>> The changes to *LTOCodeGenerator and the test using llvm-lto are unrelated to lld (they are the old LTO API used by ld64). So they should be moved to a different patch or the patch name changed. Would be good to add llvm-lto2 tests which exercise the new LTO API changed in LTO.cpp, LTOBackend.cpp etc. Note those changes are broader than just lld (also used by gold-plugin).
>
> I have removed the change to llvm-lto and added support in llvm-lto2. The new option is not exposed to ld.gold, so it is not affected.

You might as well have the legacy LTO and llvm-lto support, presumably it could be useful for ld64 etc that use it. Since you already implemented it.

And I suggest adding the support to gold-plugin.cpp as well (added a comment to one of your follow on patches to this effect as well).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85809/new/

https://reviews.llvm.org/D85809