[PATCH] D85963: [SLC] sprintf(dst, "%s", str) -> strcpy(dst, str)

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

In the case where we need the return value, there are a couple possible modifications:

1. Maybe worth checking if the length of the string is a known constant.
2. We could consider using stpcpy on targets where it's available.



================
Comment at: llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp:2501
+                      llvm::shouldOptimizeForSize(CI->getParent(), PSI, BFI,
+                                                  PGSOQueryType::IRPass);
+    if (OptForSize)
----------------
I don't think I've seen this `hasOptSize() || shouldOptimizeForSize()` pattern before; is there documentation anywhere?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85963/new/

https://reviews.llvm.org/D85963