[PATCH] D85667: Reset PAL metadata when AMDGPU traget stream finishes

David Stuttard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 14 06:51:14 PDT 2020


dstuttard added a reviewer: tpr.
dstuttard added a comment.

LGTM (minor comment typo), but I'm adding Tim who did most of the original code I think.



================
Comment at: llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp:175
+
+  // Reset the pal metadata so is data will not affect a compilation that reuses
+  // this object.
----------------
its?


================
Comment at: llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp:440
+
+  // Reset the pal metadata so is data will not affect a compilation that reuses
+  // this object.
----------------
its?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85667/new/

https://reviews.llvm.org/D85667



More information about the llvm-commits mailing list