[PATCH] D84420: [AMDGPU] Add v3f16/v3i16 support to SDag

[Sebastian Neubauer via Phabricator via llvm-commits]

Flakebi added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeTypes.cpp:961-962
+                          TLI.getTypeToTransformTo(*DAG.getContext(),
+                                                   Results[i].getValueType()) &&
+                      "Invalid type for widened vector");
+    if (IsWidened)
----------------
arsenm wrote:
> It looks like you intended this to be an assert?
The check was indeed copied from the assert in SetWidenedVector, thanks for the notice.
For context: We need to make this check finer so that SetWidenedVector does not get called for  return values which are not widened (like with tfe).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84420/new/

https://reviews.llvm.org/D84420