[PATCH] D84822: Add documentation for target ID and ClangOffloadBundlerFormat

Tony Tye via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 13 18:34:19 PDT 2020


t-tye added inline comments.


================
Comment at: llvm/docs/AMDGPUUsage.rst:387
+
+  *Default*
+    Specified by omitting the target feature from the target ID.
----------------
yaxunl wrote:
> arsenm wrote:
> > Default is an extremely confusing name. This should reflect that it's the universally compatible mode. AnyMode? Either? Universal?
> Another word I can think of is "General" or "Generic".
> 
> @t-tye What do you think? Thanks.
What about "any". It is short like "on" and "off" and captures what Matt suggests (a truncation of "anymode" which would imply "onmode" and "offmode" which seem a mouthful and no more obvious).

Thoughts?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84822/new/

https://reviews.llvm.org/D84822



More information about the llvm-commits mailing list