[PATCH] D85870: sanitizer_common: Introduce internal_madvise and start using it.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_solaris.cpp:79
+// is defined as g++ does on Solaris.
+extern "C" int madvise(caddr_t, size_t, int);
+
----------------
ro wrote:
> I don't know why but you reintroduced an older/broken version of the `madvise` declaration here.  The one you removed from `sanitizer_posix_libcdep.cpp` had the first arg as `void *` for a reason.
Oh, I thought that was a mistake and that madvise was supposed to be defined like this on Solaris (according to the comment that I removed on sanitizer_posix_libcdep.cpp lines 70-72, and man pages that I found online, e.g. https://docs.oracle.com/cd/E36784_01/html/E36874/madvise-3c.html). If it's actually defined to take `void *` on Solaris then I can fix it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85870/new/

https://reviews.llvm.org/D85870