[PATCH] D85772: [AMDGPU] Fix FP/BP spills when MUBUF constant offset exceeded

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 13 13:06:34 PDT 2020


arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM with test nit. We should probably consider just walking LivePhysRegs over the newly inserted instructions to avoid this kind of issue in the future



================
Comment at: llvm/test/CodeGen/AMDGPU/stack-realign.ll:332
 attributes #4 = { noinline nounwind "frame-pointer"="all"}
+attributes #5 = { noinline nounwind "amdgpu-num-vgpr"="41" }
----------------
I would like to eventually eliminate amdgpu-num-vgpr, so expressing the closest in terms of amdgpu-waves-per-eu is somewhat preferable


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85772/new/

https://reviews.llvm.org/D85772



More information about the llvm-commits mailing list