[PATCH] D85535: [OpenMPOpt][SplitMemTransfer][WIP] Splitting the runtime call __tgt_target_data_begin

[Hamilton Tobon-Mosquera via Phabricator via llvm-commits]

hamax97 added a comment.

In D85535#2215750 <https://reviews.llvm.org/D85535#2215750>, @jdoerfert wrote:

> In D85535#2215712 <https://reviews.llvm.org/D85535#2215712>, @hamax97 wrote:
>
>> In D85535#2214821 <https://reviews.llvm.org/D85535#2214821>, @jdoerfert wrote:
>>
>>> In D85535#2213698 <https://reviews.llvm.org/D85535#2213698>, @jdoerfert wrote:
>>>
>>>> Hm, is it possible to apply this one first. I think this is the easiest to approve right away, that way we have less outstanding code.
>>>
>>> WDYT?
>>
>> But we need to add the structure `MemoryTranfer` too. Also remember this assumes we moved the declarations in `OpenMPOpt.cpp` to `OpenMPOpt.h`, so we would have to put this new code into `OpenMPOpt.cpp`, which I think is not a problem at all, but just to consider it.
>
> Why do we need anything to split the runtime calls? The arguments should be sufficient for the split, no?

In that case, sure. I will do that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85535/new/

https://reviews.llvm.org/D85535