[PATCH] D85527: [AIX] Generate unique module id based on PID and timestamp

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1875
+          // path instead.
+          GlobalUniqueModuleId = llvm::itostr(sys::Process::getProcessId()) +
+                                 llvm::itostr(time(nullptr));
----------------
I believe concatenating two strings of decimal digits without a separator increases the chance of collisions. Adding a separator is low cost for the value it would bring.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85527/new/

https://reviews.llvm.org/D85527