[PATCH] D85881: Fix PR45442: Bail out when MemorySSA information is not available

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 13 11:06:25 PDT 2020


fhahn accepted this revision.
fhahn added a comment.

Thanks, LGTM although the test appease to still use branch on undef. Would be good to adjust before committing.



================
Comment at: llvm/lib/Transforms/Scalar/GVNHoist.cpp:608
       } else {
-        MemoryUseOrDef *UD = MSSA->getMemoryAccess(Insn);
-        if (safeToHoistLdSt(BB->getTerminator(), Insn, UD, K, NumBBsOnAllPaths))
-          Safe.push_back(CHI);
+        auto T = BB->getTerminator();
+        if (MemoryUseOrDef *UD = MSSA->getMemoryAccess(Insn))
----------------
nit: `auto * T`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85881/new/

https://reviews.llvm.org/D85881



More information about the llvm-commits mailing list