[PATCH] D83468: [Debuginfo] Fix for PR46653

Thu Aug 13 10:14:40 PDT 2020

Jac1494 added a comment.

>> I think I haven't quit understood what your goal is. Are you trying to avoid having the prologue end at line 0?

Yes, Also other line 0 too which is making incorrect debugging experience.

================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:107

-  MIRBuilder.setInstrAndDebugLoc(MI);
+  MIRBuilder.setInstr(MI);

----------------
aprantl wrote:
> This also looks wrong. We would be inheriting a random previous debug location for all instructions created by MIRBuilder if we did this?
Yes, I have also check the debugging experience and now it is looks correct.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83468/new/

https://reviews.llvm.org/D83468