[PATCH] D84360: [LLD][PowerPC] Implement GOT to PC-Rel relaxation

Victor Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 12 16:56:04 PDT 2020


NeHuang added inline comments.


================
Comment at: lld/ELF/Arch/PPC64.cpp:620
+    if ((insn & 0xfc000000) != 0xe4000000)
+      error ("expected a 'pld' for got-indirect to pc-relative relaxing");
+    insn &= ~0xff000000fc000000;
----------------
nemanjai wrote:
> NeHuang wrote:
> > nit: clang-format, this can be resolved before committing the changes. 
> Not sure what you mean, here. I ran `clang-format` on the patch and the pre-commit check didn't complain about the formatting.
Yeah, the `clang-format pre-check warning` is gone after I refresh the page. It could be an outdated message. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84360/new/

https://reviews.llvm.org/D84360



More information about the llvm-commits mailing list