[PATCH] D85683: [AMDGPU] Add dedicated llvm-readobj test. NFC.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with a couple of suggested simplifications.



================
Comment at: llvm/test/tools/llvm-readobj/ELF/amdgpu-elf-headers.test:1
+# RUN: yaml2obj %s --docnum=1 -o %t -DCPU=GFX600
+# RUN: llvm-readobj -h %t | FileCheck %s --match-full-lines -DFILE=%t -DCPU=GFX600 -DFLAGS=0x20 --check-prefix=GCN
----------------
There's only one file now, so you can get rid of --docnum from every yaml2obj invocation.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/amdgpu-elf-headers.test:2
+# RUN: yaml2obj %s --docnum=1 -o %t -DCPU=GFX600
+# RUN: llvm-readobj -h %t | FileCheck %s --match-full-lines -DFILE=%t -DCPU=GFX600 -DFLAGS=0x20 --check-prefix=GCN
+
----------------
Since there's now only one check prefix, let's simplify to the default `CHECK`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85683/new/

https://reviews.llvm.org/D85683