[PATCH] D85628: [HotColdSplitting] Add command line options for supplying cold function names via user input.

[Aditya Kumar via Phabricator via llvm-commits]

hiraditya added a comment.

> The patch looks legit. Wonder if such a patch should be sent to libstdc++ too.

Sending it shortly.

> But will the compiler see these declarations though when compiling a source file containing a local static variable, in a way that will let it propagate coldness from the __attribute__((cold))? Or does the compiler have built-in knowledge of these functions - presumably it does since it emits calls to them - and will the compiler's built-in knowledge need to be extended in addition to this patch?

The compiler will see the declaration while analyzing a callsite.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85628/new/

https://reviews.llvm.org/D85628