[PATCH] D84770: [llvm-libtool-darwin] Add support for -arch_only

Thu Aug 13 06:16:10 PDT 2020

sameerarora101 added a comment.

In D84770#2214390 <https://reviews.llvm.org/D84770#2214390>, @smeenai wrote:

> LGTM.
>
> Let's commit this one as-is, and you can add arm64v8 to TextAPI and add the corresponding test here as a follow-up.

Got it. I also realized yesterday that adding `arm64v8` to TextAPI is not the only thing necessary for supporting v8 tests. We would have to update `llvm/lib/Object/MachOObjectFile.cpp ` file as well to be able to recognize the `Triple()` correctly. I saw your response on D85334 <https://reviews.llvm.org/D85334>. It makes more sense to add the test after arm64e/arm64v8 support is there (as separate patch only). Thanks, I'll commit this now

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84770/new/

https://reviews.llvm.org/D84770