[PATCH] D85825: [ARM] Enabled VMLAV and Add instructions to use VMLAVA

[Dave Green via Phabricator via llvm-commits]

dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

This seems good to me.

The part I am a little unsure about is that it is converting add(vmlav) into a new vmlava, but we are starting at the vmlav to do it. So need to set the insertion point and use replaceAllUsesWith/eraseInstFromFunction. I couldn't find anything else that worked like that in instcombine, but maybe just missed it. It seems to work just fine like this, but it might be cause potential problems with the way instcombine iterates? It hasn't caused any problems we have seen though.

I think this is good, but give it a day or two before committing in case anyone knows that this will be a problem.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85825/new/

https://reviews.llvm.org/D85825