[PATCH] D85827: [test] XFAIL two tests with inlining debug info issues on Sparc

Thu Aug 13 02:03:19 PDT 2020

ro added a comment.

In D85827#2214085 <https://reviews.llvm.org/D85827#2214085>, @dblaikie wrote:

> did this regress recently? Did sparc start using instruction bundles recently? (I've commented on the bugs that it looks like they're both caused to the same bundling of add+ret)

I've just checked: the `debug-label-inline.ll` has already been broken when it was introduced in LLVM 8.  The `subprogram-linkonce-weak.ll` test OTOH had worked in LLVM 6 and 8, but started to fail with 9.

AFAICT the Sparc target has been using bundles already in LLVM 3.9; introduced at some point after 3.4.

> If it was recenty, I'd push back on the bundling change & suggest this needs to be fixed rather than XFAILed. If it's been broken for ages - how? who's working on sparc that they didn't notice the breakage when they committed the bundling changes in the first place?

Good question about the Sparc port: it seems not to have seen much love recently.  My current goal is to get the Solaris/Sparc port to a point where there are no unaccounted failures and the buildbot can be moved back to the regular buildmaster so new failures are noticed quickly.

> But I guess if it's been broken for a while, it's reasonable to commit this patch & have followup via bugs.

Good.  Thanks for your detective work.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85827/new/

https://reviews.llvm.org/D85827