[PATCH] D85732: [compiler-rt][asan][test] Skipt sanitizer_common tests on Sparc

[Rainer Orth via Phabricator via llvm-commits]

ro added a comment.

In D85732#2214717 <https://reviews.llvm.org/D85732#2214717>, @vitalybuka wrote:

> I would be nice to have some sparc build bot.

As it happens, we do <http://lab.llvm.org:8014/builders/clang-solaris11-sparcv9>.  However, this doesn't help unfortunately since the `sanitizer_common` testsuite wasn't enable on Solaris.

`compiler-rt` (like the rest of LLVM` has the unfortunately habit of spreading testsuite configration over far too many places (cmake files, lit config both static and with substitutions), so it's easy to miss one.

When I landed the Solaris ports (both sparc and i386), I completely missed to enable testing `sanitizer_common` (and `ubsan_minimal`) on Solaris.  The port had been developed in the `gcc` tree and I was barely familiar with cmake and lit at the time.  Even now, it would be way better to have the testsuite enabled everywhere by default and only disable parts that need a particular feature **based on that feature  rather than static configuration**.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85732/new/

https://reviews.llvm.org/D85732