[PATCH] D84519: [llvm-objdump][AMDGPU] Detect CPU string

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 13 00:22:07 PDT 2020


jhenderson added inline comments.


================
Comment at: llvm/include/llvm/Object/ELFObjectFile.h:91
+
+  StringRef getAMDGPUCPUName() const;
+
----------------
I know it's not the way the `get*Features` methods are written, but perhaps this should be a private method?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84519/new/

https://reviews.llvm.org/D84519



More information about the llvm-commits mailing list