[PATCH] D85785: [ELF] -r: allow section type 0x70000001 (SHT_X86_64_UNWIND) to be merged into SHT_PROGBITS

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D85785#2212794 <https://reviews.llvm.org/D85785#2212794>, @grimar wrote:

>> There is little cost losing the "section type mismatch" diagnostic for other architectures, so we don't bother checking e_machine
>
> Is there any reason why you don't want to check the `e_machine` to make the code more readable, straightforward and
> don't lose the "section type mismatch" diagnostic?

Because I don't think the "section type mismatch" diagnostic is useful for any `SHT_*_UNWIND`.

However, given the previous comment about SHT_ARM_EXIDX, I think checking config->e_machine may be fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85785/new/

https://reviews.llvm.org/D85785