[PATCH] D84334: [flang] Version information in flang/f18

David Truby via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 12 17:13:26 PDT 2020


DavidTruby added a comment.

In D84334#2214441 <https://reviews.llvm.org/D84334#2214441>, @coti wrote:

> @DavidTruby so, how about replacing:
>
>   set(include ${FLANG_BINARY_DIR}/include/flang)
>   
>   set(include ${FLANG_BINARY_DIR}/include/flang)
>   set(include ${CMAKE_CURRENT_BINARY_DIR})
>
> with:
>
>   target_include_directories(f18
>     ${CMAKE_CURRENT_BINARY_DIR}
>     ${FLANG_BINARY_DIR}/include/flang 
>   )

looks good to me!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84334/new/

https://reviews.llvm.org/D84334



More information about the llvm-commits mailing list